Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan: add vcr plugin for stricter checks #457

Open
dbu opened this issue Jun 11, 2024 · 0 comments
Open

phpstan: add vcr plugin for stricter checks #457

dbu opened this issue Jun 11, 2024 · 0 comments

Comments

@dbu
Copy link
Collaborator

dbu commented Jun 11, 2024

as per discusssion we should add a composer require the vcr plugin in a first step of the phpstan job, to have it validate correctly. the php tests would discover if we messed up with validation.

some nice to haves would be to have the configuration class error when configuring without vcr without having the plugin installed, and https://github.com/php-http/HttplugBundle/blob/b7ad2c1951edec36ef0bd9897e309b0038c59a54/src/DependencyInjection/HttplugExtension.php should throw an exception at the beginning of the method if vcr is not available.

@dbu dbu mentioned this issue Jun 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant