Skip to content

Fix broken profiling.formatter option #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fix broken profiling.formatter option #153

merged 1 commit into from
Apr 19, 2017
+15 −6

Conversation

fbourigault
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
Documentation N/A
License MIT

Since #128, the profiling.formatter option is broken. So there is the fix with a unit test.

@Nyholm Nyholm requested a review from sagikazarmark April 19, 2017 12:01
Nyholm
Nyholm approved these changes Apr 19, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm modified the milestone: Version 1.5.0 Apr 19, 2017
@fbourigault fbourigault merged commit f63b15e into php-http:master Apr 19, 2017
@fbourigault fbourigault deleted the fix-profiling-formatter-override branch April 19, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fbourigault @Nyholm @sagikazarmark