Skip to content

Add more tests for discovery #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2017
Merged

Add more tests for discovery #192

merged 4 commits into from
Jul 17, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 17, 2017

No description provided.

fbourigault
fbourigault approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@fbourigault fbourigault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice tests additions! I will be as happy as travis-ci

@Nyholm Nyholm merged commit 233857c into master Jul 17, 2017
@Nyholm Nyholm deleted the issue-188 branch July 17, 2017 10:02
@Nyholm
Copy link
Member Author

Nyholm commented Jul 17, 2017

Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fbourigault fbourigault fbourigault approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @fbourigault