Skip to content

Support for more clients versions #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 30, 2018
Merged

Support for more clients versions #294

merged 4 commits into from
Dec 30, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 29, 2018

No description provided.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 30, 2018

Blocked by php-http/mock-client#33

dbu
dbu approved these changes Dec 30, 2018
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to move the client adapter requires to the test matrix so we can test different options.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 30, 2018

Thank you.

@Nyholm Nyholm merged commit 9d208e2 into master Dec 30, 2018
@Nyholm Nyholm deleted the patch-client-version-bump branch December 30, 2018 11:59
@dbu dbu mentioned this pull request Dec 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @dbu