Skip to content

Make sure we have a default config for the clients variable node #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2016
Merged

Make sure we have a default config for the clients variable node #35

merged 1 commit into from
Jan 16, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 15, 2016

If you configure the bundle with:

httplug:
  clients:
    guzzle:
      factory: 'httplug.factory.guzzle6'

You would get an undefined array key error because we have no default value for the config node. This PR fix that issue.

@sagikazarmark
Copy link
Member

👍

sagikazarmark added a commit that referenced this pull request Jan 16, 2016
@sagikazarmark
Merge pull request #35 from php-http/default_config
33fbec7 
Make sure we have a default config for the clients variable node
@sagikazarmark sagikazarmark merged commit 33fbec7 into master Jan 16, 2016
@sagikazarmark sagikazarmark deleted the default_config branch January 16, 2016 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @sagikazarmark