Skip to content

make plugin service templates abstract to avoid warning #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

make plugin service templates abstract to avoid warning #383

merged 1 commit into from
Mar 30, 2020

Conversation

dbu
Copy link
Collaborator

@dbu dbu commented Mar 30, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

Make plugin service templates abstract

Why?

Avoid warning from Symfony

@Nyholm
Copy link
Member

Nyholm commented Mar 30, 2020

Could you please rebase?

@dbu dbu force-pushed the abstract-template branch from a4b6364 to 34c374f Compare March 30, 2020 07:08
@dbu
Copy link
Collaborator Author

dbu commented Mar 30, 2020

fixed

@Nyholm
Copy link
Member

Nyholm commented Mar 30, 2020

Thank you

@Nyholm Nyholm merged commit ff76ad4 into master Mar 30, 2020
@xabbuh xabbuh deleted the abstract-template branch March 31, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbu @Nyholm