Profiler: Add slash if there is none between host and path

[ostrolucky]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets
Documentation
License	MIT

What's in this PR?

See

Looks like in case target doesn't have leading slash, profiler shows strange URL

[dbu]

that is confusing. isn't that a bug in the getRequestTarget implementation, or the underlying Uri implementation? looking at https://github.com/Nyholm/psr7/blob/f734364e38a876a23be4d906a2a089e1315be18a/src/RequestTrait.php#L27 , i don't see why the leading / would get lost.

i am a bit reluctant to merge this, as i don't understand how it can happen without a (more severe) bug in the underlying request / uri implemenation. (or if it gets lost in the collector / stack, we should fix it there, but i had a look at those classes and don't see them changing the request target, they seem just data container).

also, the trim would mis-edit some weird urls like //path with double slash: https://3v4l.org/BR9Lp

[ostrolucky]

It's when path of URI is without leading slash. RequestTrait snippet you posted adds leading slash only when path is empty. And we use Guzzle btw, that also behaves this way.

[ostrolucky]

also, the trim would mis-edit some weird urls like //path with double slash: 3v4l.org/BR9Lp

I've adjusted code for this now

[dbu]

but how can the path be without leading slash?

ah, or does that happen when the uri is created withPath('no-leading/slash'), for example when the domain is configured as base on the client?

[ostrolucky]

correct