Skip to content

Conversation

sagikazarmark
Copy link
Member

No description provided.

@sagikazarmark sagikazarmark self-assigned this Nov 14, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reference is only one article...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I had more ideas in my mind with more reference, but I couldn't recall.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only specify PSR2 for the moment and remove these rules ? (To be in appliance with the .php_cs file)

After that everyone can do a pull request with a change to the .php_cs file and the documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I want to close this PR without merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth to have the deciding worklfow for new rules in the documentation WDYT ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so. I don't expect too much contribution from the community on this front.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me then.

@dbu
Copy link
Contributor

dbu commented Nov 15, 2015

i agree with this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would make this a sub-title of "Coding Standards" and call it "Additional Coding Style"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

@joelwurtz joelwurtz mentioned this pull request Dec 11, 2015
@sagikazarmark
Copy link
Member Author

Solved in #3

@sagikazarmark sagikazarmark deleted the coding_style branch December 14, 2015 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants