This repository was archived by the owner on Jan 6, 2024. It is now read-only.
allow buzz versions 0.16|0.17 #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, there seem to be actual api breaks with newer version (at least 0.17) - see https://travis-ci.org/php-http/buzz-adapter/jobs/439230909#L525 |
|
Correct. There are some BC breaks. However. The latest version of Buzz supports HTTPlug. Which means that this adapter is obsolete =) |
ah, haha! but then lets say this in the README. does 0.16 provide httplug already? or is there a gap? i guess either way we should have the readme tell that for 0.15 you can use this and if you are on (whatever supports it) just install buzz. and we could mark this repo as abandoned when the readme is updated, to avoid confusion. |
|
closing here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
see #19
Checklist