Fix deferred when in a non async context #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
FYI, it still did not solve the problem for us: https://travis-ci.org/mxr576/apigee-client-php/jobs/432968341 |
|
Are you sure that the patch is apply ? IMO this config requires an extra plugin for composer and i do not see him installed during the travis build |
|
Yes I am sure, search for "110.diff" here: https://api.travis-ci.org/v3/job/432968341/log.txt This is what I also checked first.
|
|
I've also tested this patch locally, it doesn't fix the issue. |
Merged
|
Closing this, since it's not relevant anymore and got no time to finish it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #109
Do not have time to make a proper test ATM, if urgent create a ticket for the test, merge this and push a new version
For the explanation it's because fullfilled / rejected call directly the callback before returning a new one, which makes the deferred be resolved before we set the then callback (and so the new deferred will never be resolved / rejected)