Support the PSR17 request factory #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failings are not related to my PR, and can be fixed separately. |
dbu
reviewed
Jul 1, 2020
This was referenced Jul 1, 2020
|
So it turns out this doesn't work quite how we expected! #202 should fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Http\Discovery\MessageFactoryDiscoveryis deprecated, so there is no way to discover aHttp\Message\RequestFactoryinstance using non-deprecated APIs.Http\Client\Common\HttpMethodsClientshould therefore except a PSR17 request factoryPsr\Http\Message\RequestFactoryInterfaceas well as aHttp\Message\RequestFactory.