do not specify branch name for clients to test #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
fix-dependencies
branch
3 times, most recently
from
326d7d3 to
22d7b54
Compare
|
buzz seems rather inactive... the remaining failures look like issues completely at buzz side. |
|
the socket client issue will be fixed in php-http/socket-client#72 |
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Do not specify the branch names of clients to install.
Why?
All clients renamed the branch to main or, more often, switched to semantic branch naming where the default branch is 2.x or 3.x etc.
It makes more sense for this repository to test the latest released version of the clients rather than dev versions. The clients can use this repository if they want to look at the test suite during development.