Added a discovery of classes considered as deprecated #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, never mind. I just saw this commit: a107c86 We say that we conflict with nyholm/psr7<1.0 |
|
i think that conflict is good enough as BC. pre 1.0 versions are a special thing anyways... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our BC promise we can never remove previously discovered classes.
In our current master we have removed support for nyholm/psr7:0.3.0. Im not sure nobody will notice that we break BC here. But I think we should care.
That is why I added a new strategy, just like
CommonClassesStrategybut for "deprecated" or removed classes.