Removed PHP7 code #126
Merged
Removed PHP7 code #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to keep the 1.5 branch and release a hotfix? Or dont we care because it is "just a warning"? |
|
lets tag 1.5.1 on this and then remove the branch again, i'd say. |
|
Could you really tag a commit and then remove the branch?
Hm. I’ll try
… On 30 Dec 2018, at 17:37, David Buchmann ***@***.***> wrote:
lets tag 1.5.1 on this and then remove the branch again, i'd say.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
yep you can. the tag is on the specific commit, not on a branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, I made a mistake.
This happened because we never instantiate this class.We do get an error on travis, but just a warning..
https://travis-ci.org/php-http/discovery/jobs/473566984