Add documentation for async client #21
Conversation
docs/discovery.md
Outdated
There was a problem hiding this comment.
lets say "a HttpAsyncClient" instance. from the point of the user, it only finds one.
There was a problem hiding this comment.
so "finds an installed HttpAsyncClient" ?
There was a problem hiding this comment.
i would leave out "installed", seems obvious
There was a problem hiding this comment.
I updated other lines as well to make it consistent
docs/discovery.md
Outdated
There was a problem hiding this comment.
not sure about writing this as HTTPClient - maybe with a space, so "HTTP client"?
There was a problem hiding this comment.
same for Http Async Client (to be consistent) ?
docs/tutorial.md
Outdated
There was a problem hiding this comment.
do we have discovery for this? should we, if we don't have currently?
There was a problem hiding this comment.
We do. I think I merged it today.
There was a problem hiding this comment.
then the tutorial should use it i think, instead of this line which can't be executed in reality (you would need to know your real client/adapter class name and use that instead)
|
Despite the namespace thing is there any more thing to change for this ? poke @dbu @sagikazarmark |
docs/discovery.md
Outdated
|
Added a few comments, which are mostly about some grammar and formatting issues. Apart from that, 👍 |
docs/tutorial.md
Outdated
There was a problem hiding this comment.
the part that comes after this bullet is very long. lets maybe do an overview list and then subsections with the code examples.
There was a problem hiding this comment.
Didn't catch it. You are right.
|
great! |
Related to php-http/httplug#77