Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

Add Puli bindings #14

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Conversation

dhopkalo
Copy link
Contributor

Simple change to add support puli.

I tested it and included into other my project work fine but may be it's need some ClassDiscoveryTest.php or something like this to test puli repo bindings exist ?

@sagikazarmark
Copy link
Member

Can you please make sure that the latest discovery (0.6.4) is installed? It fixes a crucial bug.

As for testing: no, I don't think it needs testing. It is configuration, like composer config.

@sagikazarmark
Copy link
Member

Fixes #12 and #13

@sagikazarmark sagikazarmark changed the title #12 - implements Puli support add bindings with "type": "Http\\Client… Add Puli bindings Jan 11, 2016
@Nyholm
Copy link
Member

Nyholm commented Jan 11, 2016

👍

@dhopkalo
Copy link
Contributor Author

To update php-http/discovery (0.6.4) we need to update php-http/adapter-integration-tests composer.json what hard requires php-http/discovery ^0.5

We can temporary fork php-http/adapter-integration-tests and change there ^0.5 -> ~0.6.4 then create pull request and rather than waiting for merging pull request we can temporary change repository link to forked php-http/adapter-integration-tests with fixed version of the php-http/discovery. If you want i will do it :)

We can't update php-http/discovery until php-http/adapter-integration-tests don't fix hard version ^0.5
php-http/adapter-integration-tests 0.2.x-dev requires php-http/discovery ^0.5 -> no matching package found.

@sagikazarmark
Copy link
Member

Oh shit, really. Okay, then I will just merge this and resolve the integration test thing manually.

sagikazarmark added a commit that referenced this pull request Jan 11, 2016
@sagikazarmark sagikazarmark merged commit 19c56c0 into php-http:master Jan 11, 2016
@dhopkalo
Copy link
Contributor Author

Thx @sagikazarmark 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants