Skip to content

Use static instead of self for instancing HttpException #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2019
Merged

Use static instead of self for instancing HttpException #153

merged 1 commit into from
Oct 2, 2019

Conversation

kpn13
Copy link

@kpn13 kpn13 commented Oct 2, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #152
Documentation n/a
License MIT

What's in this PR?

Use new static() instead of new self() for instancing Http\Client\Exception\HttpException to really instanciate the final class which called the create() method and not just the parent class.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

dbu
dbu approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit 7af4427 into php-http:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpException create method self vs static
2 participants
@kpn13 @dbu