Test on 7.4 #156
Merged
Test on 7.4 #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
thank you!
while it does not end up in an error, there is a warning in the 7.4 build because of phpspec/phpspec#1274
we seem to be on phpspec 2.4 atm, while the release that fixes the warning is phpspec 6.1 😱
i will merge as is, as its only a warning about the testing toolchain. if you want to try to upgrade the project to use phpspec 6.1 that would be awesome. (you'd need to allow some older phpspec version still, if we can support both, as 6.1 is only for php 7.2 and newer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.4 released, and we need run tests for 7.4 too