mention ivory in the readme #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be careful with the name 'Ivory'. It is a vendor name as well, not just the name for the HTTP Adapter package. |
|
better? |
|
👍 |
|
I just added a note in the readme about the deprecation and these set of packages. |
|
I think I will deprecate it officially in composer when the 1.0 is out here. |
| @@ -25,6 +25,7 @@ $ composer require php-http/httplug | |||
|
|
|||
| This is the contract package for HTTP Client. Use it to create HTTP Clients which are interoperable and compatible with [PSR-7](http://www.php-fig.org/psr/psr-7/). | |||
|
|
|||
| This library is the official successor of the [ivory http adapter](https://github.com/egeloen/ivory-http-adapter) and the code is based on the ivory http adapter code. | |||
There was a problem hiding this comment.
Ivory http adapter and code expressions are repeated here. Can we make it simpler? Also, the code is completely refactored. Actually it has been refactored several times. I think it is enough to mention that the idea is from ivory, it evolved from an adapter package to a PSR-7 HTTP Client abstraction and it is a successor of IHA.
dbu
force-pushed
the
mention-ivory-readme
branch
from
a947179 to
87955d7
Compare
|
thanks a lot egeloen! i updated the text a bit. ok @sagikazarmark ? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid confusion. ideally, @egeloen would add some note in ivory about this as well. (for now maybe with a warning that this one is not yet ready for production)