-
Notifications
You must be signed in to change notification settings - Fork 3
Add discovery package #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -16,7 +16,8 @@ | |||
"php-http/message": "^1.3", | |||
"php-http/client-common": "^1.2", | |||
"php-http/cache-plugin": "^1.0", | |||
"php-http/logger-plugin": "^1.0" | |||
"php-http/logger-plugin": "^1.0", | |||
"php-http/discovery": "^1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, it's done ;)
Thank you for this PR. The discovery is needed. |
416194f
to
9dffb35
Compare
9dffb35
to
be3c6cb
Compare
@Nyholm I thin client-common is needed too? |
Client common is already required, right? |
In fact yes, but when I try to use
EDIT: I just run |
Yes, Ill make sure to merge this PR as soon as the tests are green |
It miss |
@joelwurtz @Nyholm done |
LGTM |
Thank you ! |
No description provided.