Skip to content

Conversation

welcoMattic
Copy link
Contributor

No description provided.

@@ -16,7 +16,8 @@
"php-http/message": "^1.3",
"php-http/client-common": "^1.2",
"php-http/cache-plugin": "^1.0",
"php-http/logger-plugin": "^1.0"
"php-http/logger-plugin": "^1.0",
"php-http/discovery": "^1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, it's done ;)

@Nyholm
Copy link
Member

Nyholm commented Aug 23, 2016

Thank you for this PR. The discovery is needed.
Could you check the indentation?

@welcoMattic welcoMattic force-pushed the fix/missing-discovery branch from 416194f to 9dffb35 Compare August 23, 2016 12:14
@welcoMattic welcoMattic force-pushed the fix/missing-discovery branch from 9dffb35 to be3c6cb Compare August 23, 2016 12:15
@welcoMattic
Copy link
Contributor Author

@Nyholm I thin client-common is needed too?

@Nyholm
Copy link
Member

Nyholm commented Aug 23, 2016

Client common is already required, right?

@welcoMattic
Copy link
Contributor Author

welcoMattic commented Aug 23, 2016

In fact yes, but when I try to use Httplug::sendRequest($request);, I catch an error like:

Class 'Http\Adapter\Guzzle6\Client' not found

EDIT: I just run composer require php-http/guzzle6-adapter and magic happens ;)

@Nyholm
Copy link
Member

Nyholm commented Aug 23, 2016

Yes, composer require php-http/guzzle6-adapter is what was missing in your app.

Ill make sure to merge this PR as soon as the tests are green

@joelwurtz
Copy link
Member

It miss "php-http/client-implementation": "^1.0" so the error of not found client will be thrown by composer and not discovery

@welcoMattic
Copy link
Contributor Author

@joelwurtz @Nyholm done

@joelwurtz
Copy link
Member

LGTM

@Nyholm Nyholm merged commit fcc84f7 into master Aug 23, 2016
@Nyholm
Copy link
Member

Nyholm commented Aug 23, 2016

Thank you !

@Nyholm Nyholm deleted the fix/missing-discovery branch August 23, 2016 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants