Resolves issue #43

[peter279k]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	issue #43
Documentation	N/A
License	MIT

Closes #43.

What's in this PR?

• Using the hash('sha512') to replace sha1 function.

Checklist

• Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
• Documentation pull request created (if not simply a bugfix)

[dbu]

thanks a lot for picking this one up!

i added some suggestions. @sagikazarmark do we need to worry about a BC break when the default changes from sha1 to sha512?

[dbu]

finally got around to look at this. can we make the hashing completely configurable, while we are at it?

[peter279k]

Fix static analysis issue via PHPStan:

 ------ -------------------------------------------------------------- 
  Line   CookieJar.php                                                 
 ------ -------------------------------------------------------------- 
  15     Property Http\Message\CookieJar::$cookies with generic class  
         SplObjectStorage does not specify its types: TObject, TData   
         💡 You can turn this off by setting                            
         checkGenericClassInNonGenericObjectType: false in your        
         phpstan.neon.dist.                                            
 ------ -------------------------------------------------------------- 

[peter279k]

Fix coding style issue:

 2) src/Encoding/FilteredStream.php
      ---------- begin diff ----------
--- Original
+++ New
@@ -13,12 +13,11 @@
  */
 abstract class FilteredStream implements StreamInterface
 {
-    const BUFFER_SIZE = 8192;
-
     use StreamDecorator {
         rewind as private doRewind;
         seek as private doSeek;
     }
+    const BUFFER_SIZE = 8192;
 
     /**
      * @var callable

      ----------- end diff -----------

[dbu]

thanks a lot for the contribution, and thanks for your patience while we sorted this out. this looks ready to merge to me.

@php-http/core any further input or fine if merge and tag version 1.11.0 with this?

[dbu]

thanks a lot! i added documentation about this in php-http/documentation@aaeef9c and released this as https://github.com/php-http/message/releases/tag/1.11.0

if you have time to add a configuration option to the symfony bundle as well, that would be neat: https://github.com/php-http/HttplugBundle