Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTPlug 2 (and PSR-18) #26

Closed
Jean85 opened this issue Oct 31, 2018 · 5 comments · Fixed by #33
Closed

Support HTTPlug 2 (and PSR-18) #26

Jean85 opened this issue Oct 31, 2018 · 5 comments · Fixed by #33

Comments

@Jean85
Copy link

Jean85 commented Oct 31, 2018

Q A
Bug? no
New Feature? yes

Actual Behavior

Package is currently not compatible with HTTPlug 2

Expected Behavior

Editing the composer.json constraint to allow it

Possible Solutions

This issue until a new release of php-http/client-common will support HTTPlug 2 too, so it is blocked by php-http/client-common#114

@Nyholm
Copy link
Member

Nyholm commented Dec 30, 2018

Wohoo!
Dev-master and not-yet-released 1.2 will support this

@JaZo
Copy link

JaZo commented Jan 18, 2019

@Nyholm, when can we expect 1.2 to be released? Are there any outstanding issues that need to be resolved? I'm waiting for a HTTPlug 2 compatible release so I can update swisnl/php-http-fixture-client to make it compatible with HTTPlug 2.

@dbu
Copy link
Contributor

dbu commented Jan 20, 2019

looking at 1.1.0...master i think we are ready to release the mock-client. as long as client-common is not released, you can't have a stable release with httplug 2, but we don't miss much for client-common either.

@Nyholm okay if i tag the mock-client or do we wait for something?

@Nyholm
Copy link
Member

Nyholm commented Jan 20, 2019

Im okey with releasing 1.2.0 now.

A few weeks ago we discussed that we should wait for the release of client-common 2.0. As that work is almost finished I dont see any reason why we could not release 1.2 now.

@dbu
Copy link
Contributor

dbu commented Jan 20, 2019

tagged the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants