Add mock adapter implementation #1
Conversation
| public function clear() | ||
| { | ||
| $this->exception = null; | ||
| } |
There was a problem hiding this comment.
Should we just remove the clear() method and document that users can always create a new Mock adapter if they want to set different mock exceptions or responses?
There was a problem hiding this comment.
I think symfony's similar client implementation can also be created on demand, so a clear method is probably not necessary.
|
Of course, this mock-adapter doesn’t really adapt anything so isn’t really an adapter. Is that a problem? Does this need to be renamed to mock-client instead? |
|
I think we originally planned it to be mock-client, not sure why it ended up as an adapter. |
|
You can rename the package and the repository, I will remove the old package from packagist and readd it as soon as this gets merged. |
ddeboer
force-pushed
the
implementation
branch
from
aea6612 to
7be0d14
Compare
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function sendRequest(RequestInterface $request) |
There was a problem hiding this comment.
@sagikazarmark What is the recommended way: implement sendRequest() with HttpAsyncClientEmulator or implement sendAsyncRequest() with HttpClientEmulator?
There was a problem hiding this comment.
I don't think it really matters in this case. It is probably fine this way. Since we don't need async by the nature of this client, using async first would mean you have to convert responses to promise first, and then convert back. This way we only need one conversion.
Add mock adapter implementation
No description provided.