Skip to content

Fixed typos #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2020
Merged

Fixed typos #43

merged 1 commit into from
Jul 4, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 3, 2020 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Fixes typos causing PHPStan to be sad when analyzing my project:

  97     Parameter #1 $streamFactory of class Http\Message\MultipartStream\MultipartStreamBuilder constructor expects  
         Http\Message\MultipartStream\StreamFactory|Psr\Http\Message\StreamFactoryInterface|null,                      
         Http\Message\StreamFactory given.                                                                             
  136    Parameter #1 $streamFactory of class Http\Message\MultipartStream\MultipartStreamBuilder constructor expects  
         Http\Message\MultipartStream\StreamFactory|Psr\Http\Message\StreamFactoryInterface|null,                      
         Http\Message\StreamFactory given.

Closes #41.

@dbu dbu merged commit 9dd5300 into php-http:master Jul 4, 2020
@GrahamCampbell GrahamCampbell deleted the patch-1 branch July 4, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad ? annotation on MultipartStreamBuilder
2 participants
@GrahamCampbell @dbu