Skip to content

Add initial documentation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add initial documentation #38

wants to merge 5 commits into from

Conversation

sagikazarmark
Copy link
Member

No description provided.

xabbuh
xabbuh reviewed Dec 29, 2015
View reviewed changes
docs/implement-your-own.md

```php
/**
* Handles the request and returns the response coming from the next callable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually true? I mean a plugin could also replace the response coming from the next callable (for example, to filter it), couldn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you also do something like that (modifying the response) in one example below.

@sagikazarmark
Copy link
Member Author

@xabbuh Thanks for the feedback. This was just a PoC PR to see how documentation in plugins repo would work.

I will apply your fixes and move the stuff back to the main documentation.

@sagikazarmark sagikazarmark deleted the documentation branch December 29, 2015 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagikazarmark @xabbuh