Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel function on interface #22

Closed
wants to merge 2 commits into from
Closed

cancel function on interface #22

wants to merge 2 commits into from

Conversation

tolgaulas
Copy link

@tolgaulas tolgaulas commented Oct 20, 2021 •
edited

Fixes #21

@dbu
Copy link
Contributor

dbu commented Oct 20, 2021

hi, thanks for the input.
adding a method to an interface is a BC break, as classes that do not implement cancel (or implement it with a different signature) will suddenly break (thats also why the tests now fail).

@Nyholm @sagikazarmark what do you think about this? should the php-http promise get a new major version with a cancel method?

@dbu dbu mentioned this pull request Oct 20, 2021
Merged
@Nyholm
Copy link
Member

Nyholm commented Dec 19, 2021

The diff is currently empty.

@dbu dbu closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cancel function is missing on promises.
3 participants
@tolgaulas @dbu @Nyholm