Skip to content

Update some TestCases with issues #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2017
Merged

Update some TestCases with issues #14

merged 1 commit into from
Jul 6, 2017

Conversation

danopz
Copy link
Contributor

@danopz danopz commented Jul 6, 2017

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets partially #7
License MIT

What's in this PR?

  • Fixes an issue where an integer is set to ServerRequest::withParsedBody which should cause an InvalidArgumentException as it is defined like:
    • @param null|array|object $data
    • @throws \InvalidArgumentException if an unsupported argument type is provided.
  • Also added invalid Testcases for this
  • Updated StreamTest::testToStringReadOnlyStreams to use current file for test instead of remote
    • so we do not depend on a remote file and
    • the remote file doesn't work here

@Nyholm
Copy link
Member

Nyholm commented Jul 6, 2017

Thank you. I think it looks good. Could you fix the style issues?

@danopz
update test for ServerRequest::getParsedBody to respect thrown Invali…
41c5502 
…dArgumentException, update test for Stream::_toString to use a better read-only stream which works
@danopz
Copy link
Contributor Author

danopz commented Jul 6, 2017

@Nyholm done

@Nyholm Nyholm merged commit cc2a34a into php-http:master Jul 6, 2017
@danopz danopz deleted the fix-tests branch July 6, 2017 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danopz @Nyholm