Some changes in composer.json #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated php version to php5.5 Class name resolution via ::class is not supported in php 5.4 changed path in script test, composer knows all vendor bins
|
Are you sure composer knows the vendor bin? I’ve never seen that before. I would like to have PHPUnit in require. This library provides tests. PHPUnit is actually a dependency. Most other libraries use PHPUnit as a tool to run tests. For those libraries it make sense to have it in require-dev 👍 I like this cleanup! |
|
you can find it her https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why?
is much cleaner like this