Skip to content

Allow marking testPathWithMultipleSlashes skipped #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

nbayramberdiyev
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets -
License MIT

What's in this PR?

This PR allows marking the testPathWithMultipleSlashes method skipped.

@dbu dbu merged commit 696a1ba into php-http:master Apr 4, 2022
@dbu
Copy link
Contributor

dbu commented Apr 4, 2022

out of interest: which implementation is not respecting this rule?

@nbayramberdiyev nbayramberdiyev deleted the add-skip-check branch April 4, 2022 20:06
@nbayramberdiyev
Copy link
Contributor Author

laminas/laminas-diactoros doesn't respect this RFC (for now) causing tests to fail. Also, see this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants