Improve package #15
Merged
Improve package #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Changed | ||
|
|
||
| - Updated discovery dependency |
There was a problem hiding this comment.
Sorry, I forgot about changelog again...
|
I see that you've prepared to release 0.3.0. I see no need for that. Not until there is a code change. |
|
Why is travis not working? |
|
It is slow.. It has been for the last 4 hours.. Packagist is also having issues... |
|
It is slow.. It has been for the last 4 hours.. Packagist is also having
issues...
with the amounts of merges and tagging, it might also be that we have a
very full pipeline. afaik each organization has a limited number of
parallel builds, so when a lot happens, things tend to get clogged up.
it should catch up over the night or whenever we stop doing so many
chances :-)
|
|
That is true, but I've experienced slow travis on other organisations today as well.. |
sagikazarmark
force-pushed
the
improve_package
branch
2 times, most recently
from
73434fa to
7c4e1cc
Compare
|
|
||
| For a deeper `async` comprehension, you must check how ReactPHP engine work. | ||
| Please see the [official documentation](http://docs.php-http.org/en/latest/clients/guzzle5-adapter.html). |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, I concentrated so hard no to mess it up....
|
Good, just update the link and I'm happy to merge |
sagikazarmark
force-pushed
the
improve_package
branch
from
7c4e1cc to
1ae413f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.