Added travis file from symfony best practices #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2017
Closed
dunglas
approved these changes
Nov 29, 2017
dbu
reviewed
Nov 30, 2017
| @@ -21,35 +16,44 @@ branches: | |||
| matrix: | |||
| fast_finish: true | |||
| include: | |||
| # Test stable versions | |||
| # Test with lowest dependencies | |||
| - php: 7.1 | |||
There was a problem hiding this comment.
imho this should also be the oldest php version we support to really get the oldest possible thing
dbu
approved these changes
Dec 1, 2017
|
are you happy with this as is, or do you want to wait for further input on the symfony-docs pull request? |
fbourigault
approved these changes
Dec 1, 2017
|
I’m very happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also test dunglas/symfony-lock