Skip to content

coverage is no longer working, drop that build #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
name: tests

on:
push:
pull_request:
push:
branches:
- '[0-9]+.x'
- '[0-9]+.[0-9]+'
- '[0-9]+.[0-9]+.x'

jobs:
latest:
Expand Down Expand Up @@ -48,8 +52,8 @@ jobs:
- name: Execute tests
run: composer test

coverage:
name: Code coverage and static analysis
static:
name: Static analysis
runs-on: ubuntu-latest

steps:
Expand All @@ -59,16 +63,11 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.0
coverage: xdebug
php-version: 8.2
coverage: none

- name: Install dependencies
run: composer update --prefer-dist --no-interaction --no-progress

- name: Execute tests
run: composer test-ci

- name: Upload coverage
run: |
wget https://scrutinizer-ci.com/ocular.phar
php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml
run: composer test-static
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ $replay = new ReplayPlugin($namingStrategy, $recorder);

``` bash
$ composer test
$ composer test-static
```


Expand Down
10 changes: 1 addition & 9 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,7 @@
},
"scripts": {
"test": "vendor/bin/simple-phpunit",
"test-ci": [
"vendor/bin/simple-phpunit --coverage-text --coverage-clover=build/coverage.xml",
"vendor/bin/phpstan analyse src -l 8"
]
},
"extra": {
"branch-alias": {
"dev-master": "1.0-dev"
}
"test-static": "vendor/bin/phpstan"
},
"prefer-stable": true,
"minimum-stability": "dev"
Expand Down
5 changes: 0 additions & 5 deletions phpstan.neon

This file was deleted.

8 changes: 8 additions & 0 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
parameters:
level: 8
paths:
- src/
ignoreErrors:
# The logger is initialized to NullLogger in the constructor of the FilesystemRecorder, but phpstan does not see that
- message: '#Cannot call method debug\(\) on Psr\\Log\\LoggerInterface\|null#'
path: src/Recorder/FilesystemRecorder.php