Skip to content

Remove WIP warning #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Remove WIP warning #6

merged 1 commit into from
Nov 19, 2019

Conversation

GaryPEGEOT
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

Why?

Not really WIP anymore :) Might want to tag the first version as well?

Not really WIP anymore :) Might want to tag the first version as well?
@dbu
Copy link
Contributor

dbu commented Nov 19, 2019

sounds good. i invited you as a collaborator so that you are able to do releases and merge PRs.

i suggest that when you do changes, you still do pull requests and ask for peer reviews.

@GaryPEGEOT
Copy link
Collaborator Author

Great thanks !

i suggest that when you do changes, you still do pull requests and ask for peer reviews.

Sure, no problem :)

@dbu dbu merged commit f834589 into php-http:master Nov 19, 2019
@dbu
Copy link
Contributor

dbu commented Nov 19, 2019

feel free to release 👍

(don't forget to update the changelog file before you do, and maybe check if there is anything you wanted to clean up in the config or code)

@GaryPEGEOT GaryPEGEOT deleted the patch-1 branch November 19, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants