Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Conversation

chr-hertel
Copy link
Member

Following up on #143 - cannot reproduce the issue anymore 🤔

@DZunke do you still recall what happened?

@DZunke
Copy link
Contributor

DZunke commented Feb 5, 2025

@chr-hertel was nothing big. After the library was updated i had the problem during a Pull Request building when i executed the testsuite. As mentioned in #143 the tets ChainProcessorTest failed with the error there.

In december they published a new patch for compatibility with phpstan 2, so maybe the lexer is now working as the error came from a phpstan library.

https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.1

Maybe the conflict is not needed anymore after mid of december.

@chr-hertel
Copy link
Member Author

Thanks, yes, saw that and was just wondering because i couldn't even reproduce with 5.6.0 but nvm - looks like it's gone for good :)

@chr-hertel chr-hertel merged commit 06e52f1 into main Feb 5, 2025
7 checks passed
@chr-hertel chr-hertel deleted the chore-remove-conflict branch February 5, 2025 19:52
@chr-hertel chr-hertel added the chore House keeping label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore House keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants