This repository was archived by the owner on Jul 16, 2025. It is now read-only.
feat: remove dependency on llm-chain #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
changed the title
|
i wonder if the toolbox thingy should be decoupled from llm-chain anyways in a separat package that than could have a bridge to this one. |
chr-hertel
reviewed
May 25, 2025
|
|
||
| namespace PhpLlm\McpSdk\Exception; | ||
|
|
||
| use PhpLlm\LlmChain\Exception\ExceptionInterface as BaseExceptionInterface; |
There was a problem hiding this comment.
is it still intended to have the dependency here? looks wrong to me
chr-hertel
reviewed
May 25, 2025
| use PhpLlm\McpSdk\Message\Error; | ||
| use PhpLlm\McpSdk\Message\Request; | ||
| use PhpLlm\McpSdk\Message\Response; | ||
|
|
||
| final class ToolCallHandler extends BaseRequestHandler | ||
| { | ||
| public function __construct( | ||
| private readonly ToolboxInterface $toolbox, | ||
| private readonly ToolExecutorInterface $toolbox, |
There was a problem hiding this comment.
Suggested change
| private readonly ToolExecutorInterface $toolbox, | |
| private readonly ToolExecutorInterface $toolExecutor, |
chr-hertel
reviewed
May 25, 2025
| use PhpLlm\McpSdk\Message\Request; | ||
| use PhpLlm\McpSdk\Message\Response; | ||
|
|
||
| final class ToolListHandler extends BaseRequestHandler | ||
| { | ||
| public function __construct( | ||
| private readonly ToolboxInterface $toolbox, | ||
| private readonly ToolCollectionInterface $toolbox, |
There was a problem hiding this comment.
Suggested change
| private readonly ToolCollectionInterface $toolbox, | |
| private readonly ToolCollectionInterface $toolCollection, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like this package to be the low-level package. Ie, we cannot have a dependency to the high-level
php-llm/llm-chain.I have moved models and interfaces to this package. These will of course be part of the contract. I'll continue this work with adding support other capabilities like for Resources and Prompts