Skip to content

Unify lock/unlock methods visibility #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

Unify lock/unlock methods visibility #62

merged 1 commit into from
Dec 6, 2024

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 6, 2024

In LockMutex these methods are protected, so keep them protected everywhere.

BC break: You cannot call {MySQLMutex, PgAdvisoryLockMutex}::{lock, unlock}() methods manually

Call {MySQLMutex, PgAdvisoryLockMutex}::synchronized method instead.

@mvorisek mvorisek changed the title Do not extend lock/unlock methods visibility Unify lock/unlock methods visibility Dec 6, 2024
@mvorisek mvorisek marked this pull request as ready for review December 6, 2024 14:56
@mvorisek mvorisek merged commit d1b2453 into master Dec 6, 2024
28 checks passed
@mvorisek mvorisek deleted the lock_protected branch December 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvorisek