More tests pass now #163
Merged
More tests pass now #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkoppanen there are 5 failures left that don't look related to PHP 7. And some failures due to different error messages from tests/experimental |
|
Hey, tests/experimental are in experimental state. I'll merge this and we can fix any issues that potentially arise later on. |
|
Right, I understand, but there is still the failing gh_155 test which isn't in the experimental directory. Seems like that might need a skipif check on the libmemcached library or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a number of PHP 7-related issues. Still a bunch of failing tests though.