Extended key checking to match the language of the memcached spec #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This remains true for current master branch. Will adapt your fix to the new code! |
sodabrew
pushed a commit
to sodabrew/php-memcached
that referenced
this pull request
Jan 24, 2017
…p-memcached-dev#167) Updated to php7 branch by Aaron Stone <aaron@serendipity.cx>
sodabrew
pushed a commit
to sodabrew/php-memcached
that referenced
this pull request
Jan 24, 2017
…p-memcached-dev#167) Updated to php7 branch by Aaron Stone <aaron@serendipity.cx>
sodabrew
pushed a commit
to sodabrew/php-memcached
that referenced
this pull request
Jan 24, 2017
…p-memcached-dev#167) Updated to php7 branch by Aaron Stone <aaron@serendipity.cx>
sodabrew
pushed a commit
to sodabrew/php-memcached
that referenced
this pull request
Jan 24, 2017
…p-memcached-dev#167) Updated to php7 branch by Aaron Stone <aaron@serendipity.cx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this bug report. Memcached doesn't support keys containing whitespace or control characters, so it might be best to return a bad key result code rather than pass it on to the library. Dunno if this is the best approach, but it's a thought. :)