Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: store_retry_count shouldn't be set implicitly #452

Merged

Conversation

git-hulk
Copy link
Contributor

@git-hulk git-hulk commented Feb 23, 2020

It's wired that store commands would be auto-retry implicitly while the default value of store_retry_count was 2, as well as the timeout, would be 3 times in those store commands which may confuse users. IMHO, the retry should be set explicitly instead of implicitly.

It's wired that store commands would be auto-retry implicitly while the default value of store_retry_count was 2, as well as the timeout, would be 3 times in those store commands which may confuse users. IMHO, the retry should be set explicitly instead of implicitly.
@git-hulk
Copy link
Contributor Author

git-hulk commented Mar 13, 2020

@sodabrew how about this PR?

@sodabrew
Copy link
Contributor

sodabrew commented Mar 13, 2020

Maybe? Seems reasonable. I'd bump the minor version (e.g. 3.2.0) to indicate the change.

@git-hulk
Copy link
Contributor Author

git-hulk commented Mar 13, 2020

OK, thanks

@sodabrew sodabrew added this to the 3.2.0 milestone Oct 9, 2020
@sodabrew sodabrew merged commit e6df8ab into php-memcached-dev:master Aug 23, 2021
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants