Build with memcached >= 1.0.9 #80
Conversation
memcached_server_list_append_with_weight() returns a memcached_server_list_st, not a memcached_server_st *. They're currently equivalent typedefs, but as experience has shown this doesn't mean they'll be in the future.
Commit 5450f45 ported this to use the newer memcached_server_instance_st instead of the old and incorrect memcached_server_st. During this, since there's no accessor function to "weight" anymore (the internal structure is now a C++ class), getServerByKey()'s output was changed to return a dummy value of "0" for weight. Remove this dummy value altogether, as people relying on getting a weight should not get silent breakages. (this probably deserves a changelog entry)
memcached_server_instance_st is no more and surprisingly there's no deprecated typedef to help with that. Add a bunch of #ifdefs and adapt to the new API.
|
FWIW, a simple typedef const memcached_instance_st *memcached_server_instance_st;In libmemcached's deprecated_types.h would probably do the trick (untested). If that gets accepted, you could then In any case, note that the current code is buggy, because of 5450f45: in |
|
Debian's libmemcahed maintainer & myself raised this with upstream libmemcached: https://bugs.launchpad.net/libmemcached/+bug/1190240 |
|
I like how Mark is the only one commenting on that bug :\ |
|
The latest PR merged drops support for pre 1.0.9, is that actually needed? |
|
Should be fixed now |
A commit to make php-memcached build against libmemcached >= 1.0.9 (tested with 1.0.17). Unfortunately libmemcached broke API on a minor release, so we have to do #ifdef trickery. You might be better off asking libmemcached to provide some backwards compatibility, but here's the patch anyway.
Along with that, a couple of minor semi-unrelated commits.