Skip to content

ViewRelationshipAction Bug -fix #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024
Merged

ViewRelationshipAction Bug -fix #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/actions/ViewRelationshipAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,20 @@ private function resolveHasOne(ActiveQueryInterface $relation):Item
*/
private function resolveHasMany(ActiveQueryInterface $relation)
{
$dataProvider = Yii::createObject($this->dataProvider);
/**
* For the dataProvider to create a TotalCount for pagination, query must be passed first.
* @see \yii\data\ActiveDataProvider::prepareTotalCount
*/
$dataProvider = Yii::createObject(array_merge(
['query' => $relation],
$this->dataProvider,
['resourceKey' => $this->resourceKey],
['transformer' => $this->transformer],
));
if (!$dataProvider instanceof JsonApiActiveDataProvider && !$dataProvider instanceof CursorActiveDataProvider) {
throw new InvalidConfigException('Invalid dataProvider configuration');
}
$dataProvider->query = $relation;
$dataProvider->resourceKey = $this->resourceKey;
$dataProvider->transformer = $this->transformer;

$dataProvider->setSort(['params' => Yii::$app->getRequest()->getQueryParams()]);

if ($this->prepareDataProvider !== null) {
Expand Down
Loading