Fix compatibility of Kernel as HttpCache instance #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirimoya
reviewed
Jun 17, 2021
alexander-schranz
force-pushed
the
bugfix/http-cache-support
branch
from
feb1d2f to
e1d6e88
Compare
Nyholm
reviewed
Jul 2, 2021
| @@ -30,13 +32,21 @@ class Runner implements RunnerInterface | |||
| */ | |||
| private $sessionOptions; | |||
|
|
|||
| public function __construct(KernelInterface $kernel, ?HttpFoundationFactoryInterface $httpFoundationFactory = null, ?HttpMessageFactoryInterface $httpMessageFactory = null) | |||
| public function __construct(HttpKernelInterface $kernel, ?HttpFoundationFactoryInterface $httpFoundationFactory = null, ?HttpMessageFactoryInterface $httpMessageFactory = null) | |||
There was a problem hiding this comment.
Hm.. Lets drop this type hint and add HttpKernelInterface|KernelInterface in the doc block
There was a problem hiding this comment.
Thx for fixing the typehint!
Nyholm
reviewed
Jul 2, 2021
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally introduced a break in: #47 that the
HttpCacheinstance which example in Sulu is created in the Front Controller is not longer supported: https://github.com/chirimoya/sulu-skeleton-runtime/blob/30712fcfe63b14a20b636ff871e1ff02c9ec08d7/public/website.php#L23