This repository was archived by the owner on Jul 24, 2024. It is now read-only.
chore: improve performance for token stream #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azjezz <azjezz@protonmail.com>
azjezz
commented
Dec 11, 2022
Comment on lines
-90
to
+95
| pub fn current(&self) -> &Token { | ||
| let mut cursor = self.cursor; | ||
| loop { | ||
| if cursor >= self.length { | ||
| return &self.default; | ||
| } | ||
|
|
||
| let current = &self.tokens[cursor]; | ||
|
|
||
| if matches!( | ||
| current.kind, | ||
| TokenKind::SingleLineComment(_) | ||
| | TokenKind::MultiLineComment(_) | ||
| | TokenKind::HashMarkComment(_) | ||
| | TokenKind::DocumentComment(_) | ||
| ) { | ||
| cursor += 1; | ||
| continue; | ||
| } | ||
|
|
||
| return current; | ||
| pub const fn current(&self) -> &Token { | ||
| if self.cursor >= self.length { | ||
| return &self.default; | ||
| } | ||
|
|
||
| &self.tokens[self.cursor] |
There was a problem hiding this comment.
we don't need to skip comments here, ::new skips comments, and so does next(), so we know that current doesn't refer to a comment.
azjezz
commented
Dec 11, 2022
Comment on lines
+117
to
+118
| let mut cursor = self.cursor + 1; | ||
| let mut target = 1; |
There was a problem hiding this comment.
n is always >= 1, so we can start looking from cursor + 1 instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
not the best metric to go by, but it shows good improvements :)