chore: improve json representation of ast #218

azjezz · 2022-12-12T15:34:53Z

Signed-off-by: azjezz <azjezz@protonmail.com>

azjezz · 2022-12-12T15:39:33Z

src/parser/ast/declares.rs

+    // declaration is terminated with `;` after a single expression.
+    Expression {
+        expression: Expression,
+        end: Span,
+    },


it seems weird that it's an expression not a statement, but that's how PHP does it 🤷‍♂️

azjezz · 2022-12-12T15:45:58Z

src/parser/ast/declares.rs

+    pub key: SimpleIdentifier,
+    pub span: Span,
+    pub value: Expression,


key -> strict_types
span -> =
value -> 1

azjezz · 2022-12-12T15:46:45Z

src/parser/ast/declares.rs

+pub struct DeclareEntryGroup {
+    pub start: Span,
+    pub end: Span,
+    pub entries: Vec<DeclareEntry>,
+}


start -> (
end -> )
entries -> list of k=v.

we still don't keep track of comma positions, but that is planned for later.

chore: improve json representation of ast

32f3538

Signed-off-by: azjezz <azjezz@protonmail.com>

azjezz self-assigned this Dec 12, 2022

azjezz commented Dec 12, 2022

View reviewed changes

azjezz merged commit c16fc26 into main Dec 12, 2022

azjezz deleted the json2 branch December 12, 2022 15:43

azjezz commented Dec 12, 2022

View reviewed changes

Provide feedback