Skip to content

Make style props private #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Make style props private #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions src/Style/CheckboxStyle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,37 @@

class CheckboxStyle
{
protected const DEFAULT_STYLES = [
private const DEFAULT_STYLES = [
'markerOn' => '[✔] ',
'markerOff' => '[ ] ',
'itemExtra' => '✔',
'displaysExtra' => false,
];

protected $markerOn = '';

protected $markerOff = '';

protected $itemExtra = '';

protected $displaysExtra = false;

protected $custom = false;
/**
* @var string
*/
private $markerOn;

/**
* @var string
*/
private $markerOff;

/**
* @var string
*/
private $itemExtra;

/**
* @var bool
*/
private $displaysExtra;

/**
* @var bool
*/
private $custom = false;

public function __construct()
{
Expand Down
33 changes: 24 additions & 9 deletions src/Style/RadioStyle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,36 @@

class RadioStyle
{
protected const DEFAULT_STYLES = [
private const DEFAULT_STYLES = [
'markerOn' => '[●] ',
'markerOff' => '[○] ',
'itemExtra' => '✔',
'displaysExtra' => false,
];

protected $markerOn = '';

protected $markerOff = '';

protected $itemExtra = '';

protected $displaysExtra = false;

/**
* @var string
*/
private $markerOn;

/**
* @var string
*/
private $markerOff;

/**
* @var string
*/
private $itemExtra;

/**
* @var bool
*/
private $displaysExtra;

/**
* @var bool
*/
protected $custom = false;

public function __construct()
Expand Down