[FIX] deprecated function use #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AydinHassan
reviewed
Dec 15, 2021
| * | ||
| * @return string | ||
| */ | ||
| private function getForegroundColourCode(bool $bright = false) : string | ||
| private function getForegroundColourCode(?bool $bright = false) : string |
There was a problem hiding this comment.
Why is this changed? It doesn't seem related
AydinHassan
reviewed
Dec 15, 2021
| @@ -509,8 +511,8 @@ private function generatePaddingTopBottomRows() : void | |||
| ); | |||
| } | |||
|
|
|||
| $this->paddingTopBottom = $this->paddingTopBottom >= 0 ? $this->paddingTopBottom : 0; | |||
There was a problem hiding this comment.
I'm confused how this even becomes null
|
Hi @atomatis - thanks for the PR! If you don't mind, i'd like to do a little debugging tomorrow to see if we are fixing this in the correct place |
|
Hi, thank you for reactivity. It's ok. That will train me to do better next time :) |
|
It's not clumsy at all, it pointed me in the right direction so thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249