Fix PHP 8.1 deprecations #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
Coverage 93.38% 93.38%
+ Complexity 659 656 -3
=========================================
Files 38 38
Lines 1994 1994
=========================================
Hits 1862 1862
Misses 132 132
Continue to review full report at Codecov.
|
AydinHassan
force-pushed
the
fix-php81-depreactions
branch
from
78596e4
to
7536e2a
Compare
mikeymike
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These "integers" were being used in functions requiring actual integers and in a lot of the cases they were null instead. The fix is just to make sure these are real integers.