Skip to content

Conversation

lachlankrautz
Copy link
Contributor

On add submenu use "new static" not "new self"

This way a subclass of CliMenuBuilder will add sub menus of the same subclass type and not the parent class type.

This makes it easier to meaningfully extend.

@codecov-io
Copy link

Codecov Report

Merging #68 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     88.76%   88.79%   +0.03%     
- Complexity      239      241       +2     
============================================
  Files            18       18              
  Lines           730      732       +2     
============================================
+ Hits            648      650       +2     
  Misses           82       82
Impacted Files Coverage Δ Complexity Δ
src/CliMenuBuilder.php 98.7% <100%> (ø) 45 <0> (+1) ⬆️
src/CliMenu.php 89.18% <0%> (+0.07%) 55% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870340f...90a2bb3. Read the comment docs.

@AydinHassan AydinHassan merged commit 7099721 into php-school:master Dec 11, 2017
@AydinHassan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants