Skip to content

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Dec 6, 2020

  • Add a PSR-3 based logger for use in the FW
  • Also add an in memory logger for testing
  • Adds a base test classes for making some repetitive things easier, creating temp dirs
  • Adds another base test class (ContainerAware) which wires up the container, so we can test the config and mock the logger and various other things
  • Add logging to the initial code listener

@AydinHassan AydinHassan requested a review from mikeymike December 6, 2020 14:36
@codecov-io
Copy link

Codecov Report

Merging #188 (e93a6a3) into master (6657628) will decrease coverage by 0.00%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
- Coverage     95.58%   95.58%   -0.01%     
- Complexity      639      644       +5     
============================================
  Files            96       97       +1     
  Lines          1950     1971      +21     
============================================
+ Hits           1864     1884      +20     
- Misses           86       87       +1     
Impacted Files Coverage Δ Complexity Δ
src/Logger/Logger.php 92.30% <92.30%> (ø) 5.00 <5.00> (?)
src/Listener/InitialCodeListener.php 100.00% <100.00%> (ø) 5.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6657628...e93a6a3. Read the comment docs.

@AydinHassan AydinHassan merged commit 84196ec into master Dec 6, 2020
@AydinHassan AydinHassan deleted the logger branch December 6, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants