Error handling #227
Merged
Error handling #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update DI merging to let PHP-DI handle except for event listeners * Convert all notices/warnings to exceptions * Print out exceptions in full
mikeymike
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the latest workshop code with learn you PHP and it fell over quite a bit. It turns out this error handling we have is not really working. Somehow, the tear down was getting called multiple times and errors were being completely swallowed up.
I've refactored to basically convert all warnings/notices and let the exception handler deal with them and call the teardown. I've also refactored the exception message printing to include the trace and more info. We can hide that behind the debug flag if it gets too noisy.